A few minor nits, overall LGTM and still passes on FreeBSD.
================
Comment at: test/expression_command/timeout/wait-a-while.cpp:8
@@ +7,3 @@
+
+int
+wait_a_while (int microseconds)
----------------
git complained about trailing whitespace here
================
Comment at: test/functionalities/attach_resume/Makefile:4
@@ +3,3 @@
+CXX_SOURCES := main.cpp
+ifneq "$(OS)" "Windows_NT"
+ LD_EXTRAS := -lpthread
----------------
Perhaps a $(LPTHREAD) make var that is set to -lpthread or empty by an included
header?
================
Comment at: test/lldbtest.py:557
@@ -556,1 +556,3 @@
+def skipIfWindows(func):
+ """Decorate the item to skip tests that should be skipped on Windows."""
----------------
(Perhaps in a separate commit,) we should refactor the skipIf* decorators the
same way I did expectedFailure*
================
Comment at: test/make/Makefile.rules:84
@@ -80,1 +83,3 @@
endif
+ ifeq "$(ARCH)" "x86"
+ override ARCH := $(subst x86,32,$(ARCH))
----------------
probably clearer to put this with the other 32-bit cases below
================
Comment at: test/make/uncaught_exception.h:6
@@ +5,1 @@
+static void *__uncaught_exception() { return nullptr; }
\ No newline at end of file
----------------
Add newline
http://reviews.llvm.org/D4816
_______________________________________________
lldb-commits mailing list
[email protected]
http://lists.cs.uiuc.edu/mailman/listinfo/lldb-commits
