Yes your ARM64 fix looks good. > On Aug 6, 2014, at 2:28 PM, Keno Fischer <[email protected]> wrote: > > I committed just the socket change. Will hold off on the CPU_TYPE_ARM > change until somebody has a look. > > On Wed, Aug 6, 2014 at 5:27 PM, Keno Fischer > <[email protected]> wrote: >> Closed by commit rL214996 (authored by kfischer). >> >> REPOSITORY >> rL LLVM >> >> http://reviews.llvm.org/D4815 >> >> Files: >> lldb/trunk/source/Plugins/Process/MacOSX-Kernel/ProcessKDP.cpp >> >> Index: lldb/trunk/source/Plugins/Process/MacOSX-Kernel/ProcessKDP.cpp >> =================================================================== >> --- lldb/trunk/source/Plugins/Process/MacOSX-Kernel/ProcessKDP.cpp >> +++ lldb/trunk/source/Plugins/Process/MacOSX-Kernel/ProcessKDP.cpp >> @@ -22,6 +22,7 @@ >> #include "lldb/Core/UUID.h" >> #include "lldb/Host/Host.h" >> #include "lldb/Host/Symbols.h" >> +#include "lldb/Host/Socket.h" >> #include "lldb/Interpreter/CommandInterpreter.h" >> #include "lldb/Interpreter/CommandObject.h" >> #include "lldb/Interpreter/CommandObjectMultiword.h" >> @@ -272,8 +273,8 @@ >> >> if (conn_ap->IsConnected()) >> { >> - const Socket& socket = static_cast<const >> Socket&>(conn_ap->GetReadObject()); >> - const uint16_t reply_port = socket.GetPort(); >> + const Socket& socket = static_cast<const >> Socket&>(*conn_ap->GetReadObject()); >> + const uint16_t reply_port = socket.GetPortNumber(); >> >> if (reply_port != 0) >> { > _______________________________________________ > lldb-commits mailing list > [email protected] > http://lists.cs.uiuc.edu/mailman/listinfo/lldb-commits
_______________________________________________ lldb-commits mailing list [email protected] http://lists.cs.uiuc.edu/mailman/listinfo/lldb-commits
