Since this involves moving quite a bit of code around, I want to make sure it's formatted correctly. I know LLVM has an 80-column limit, but LLDB doesn't seem to adhere to the same limit. Or at least if it does, it's not consistent. Do you have a preference here? BTW, it would be nice if http://lldb.llvm.org/ outlined the ways in which the coding style for LLDB differed from the coding style for LLVM. Some rules are obvious, such as 4-space indentation, but others are not so obvious.
On Mon, Aug 18, 2014 at 4:27 PM, Greg Clayton <[email protected]> wrote: > I like the using of the C++11 <thread> for some stuff as we may be able to > use more of the C++11 standard library as the host layer for common base > classes. > > Looks good. > > > > On Aug 18, 2014, at 4:05 PM, Zachary Turner <[email protected]> wrote: > > > > This change implements the beginning of the HostInfo class - a class > whose purpose is to answer queries about the host operating system. > > > > This compiles successfully and passes all tests on Linux, MacOSX, and > Windows. I do not have access to a FreeBSD build machine, so would > appreciate help there. > > > > http://reviews.llvm.org/D4963 > > > > Files: > > include/lldb/Core/ArchSpec.h > > include/lldb/Host/Host.h > > include/lldb/Host/HostInfo.h > > include/lldb/Host/HostInfoBase.h > > include/lldb/Host/freebsd/HostInfoFreeBSD.h > > include/lldb/Host/linux/HostInfoLinux.h > > include/lldb/Host/macosx/HostInfoMacOSX.h > > include/lldb/Host/posix/HostInfoPosix.h > > include/lldb/Host/windows/HostInfoWindows.h > > include/lldb/Target/Platform.h > > lldb.xcodeproj/project.pbxproj > > source/Core/DataBufferMemoryMap.cpp > > source/Expression/ClangUserExpression.cpp > > source/Host/CMakeLists.txt > > source/Host/common/Host.cpp > > source/Host/common/HostInfoBase.cpp > > source/Host/freebsd/Host.cpp > > source/Host/freebsd/HostInfoFreeBSD.cpp > > source/Host/linux/Host.cpp > > source/Host/linux/HostInfoLinux.cpp > > source/Host/macosx/Host.mm > > source/Host/macosx/HostInfoMacOSX.mm > > source/Host/posix/HostInfoPosix.cpp > > source/Host/windows/Host.cpp > > source/Host/windows/HostInfoWindows.cpp > > source/Plugins/ObjectFile/ELF/ObjectFileELF.cpp > > source/Plugins/Platform/MacOSX/PlatformMacOSX.cpp > > source/Plugins/Platform/Windows/PlatformWindows.cpp > > source/Plugins/Process/gdb-remote/GDBRemoteCommunicationClient.cpp > > source/Plugins/Process/gdb-remote/GDBRemoteCommunicationServer.cpp > > source/Target/Platform.cpp > > source/Target/ThreadPlanCallUserExpression.cpp > > <D4963.12633.patch>_______________________________________________ > > lldb-commits mailing list > > [email protected] > > http://lists.cs.uiuc.edu/mailman/listinfo/lldb-commits > >
_______________________________________________ lldb-commits mailing list [email protected] http://lists.cs.uiuc.edu/mailman/listinfo/lldb-commits
