Nope. I don’t have committer access. On Sep 2, 2014, at 2:12 PM, Todd Fiala <[email protected]> wrote:
> LGTM. Are you able to check that in? > > > On Tue, Sep 2, 2014 at 2:05 PM, Stephane Sezer <[email protected]> wrote: > Without this, we get the following link errors: > > Undefined symbols for architecture x86_64: > > "lldb_private::HostInfoMacOSX::GetOSKernelDescription(std::__1::basic_string<char, > std::__1::char_traits<char>, std::__1::allocator<char> >&)", referenced from: > > lldb_private::Platform::GetOSKernelDescription(std::__1::basic_string<char, > std::__1::char_traits<char>, std::__1::allocator<char> >&) in > liblldbTarget.a(Platform.cpp.o) > > "lldb_private::HostInfoMacOSX::GetOSBuildString(std::__1::basic_string<char, > std::__1::char_traits<char>, std::__1::allocator<char> >&)", referenced from: > PlatformMacOSX::GetFileWithUUID(lldb_private::FileSpec const&, > lldb_private::UUID const*, lldb_private::FileSpec&) in > liblldbPluginPlatformMacOSX.a(PlatformMacOSX.cpp.o) > > lldb_private::Platform::GetOSBuildString(std::__1::basic_string<char, > std::__1::char_traits<char>, std::__1::allocator<char> >&) in > liblldbTarget.a(Platform.cpp.o) > "lldb_private::HostInfoMacOSX::GetOSVersion(unsigned int&, unsigned > int&, unsigned int&)", referenced from: > > lldb_private::Host::GetPosixspawnFlags(lldb_private::ProcessLaunchInfo&) in > liblldbHost.a(Host.cpp.o) > lldb_private::Platform::GetOSVersion(unsigned int&, unsigned int&, > unsigned int&) in liblldbTarget.a(Platform.cpp.o) > > "lldb_private::HostInfoMacOSX::ComputeHeaderDirectory(lldb_private::FileSpec&)", > referenced from: > lldb_private::HostInfoBase::GetLLDBPath(lldb::PathType, > lldb_private::FileSpec&) in liblldbHost.a(HostInfoBase.cpp.o) > > "lldb_private::HostInfoMacOSX::ComputeSupportExeDirectory(lldb_private::FileSpec&)", > referenced from: > lldb_private::HostInfoBase::GetLLDBPath(lldb::PathType, > lldb_private::FileSpec&) in liblldbHost.a(HostInfoBase.cpp.o) > > "lldb_private::HostInfoMacOSX::ComputePythonDirectory(lldb_private::FileSpec&)", > referenced from: > lldb_private::HostInfoBase::GetLLDBPath(lldb::PathType, > lldb_private::FileSpec&) in liblldbHost.a(HostInfoBase.cpp.o) > "lldb_private::HostInfoMacOSX::GetProgramFileSpec()", referenced from: > lldb::SBHostOS::GetProgramFileSpec() in liblldbAPI.a(SBHostOS.cpp.o) > lldb_private::CommandInterpreter::SourceInitFile(bool, > lldb_private::CommandReturnObject&) in > liblldbInterpreter.a(CommandInterpreter.cpp.o) > > "lldb_private::HostInfoMacOSX::ComputeSystemPluginsDirectory(lldb_private::FileSpec&)", > referenced from: > lldb_private::HostInfoBase::GetLLDBPath(lldb::PathType, > lldb_private::FileSpec&) in liblldbHost.a(HostInfoBase.cpp.o) > > "lldb_private::HostInfoMacOSX::ComputeUserPluginsDirectory(lldb_private::FileSpec&)", > referenced from: > lldb_private::HostInfoBase::GetLLDBPath(lldb::PathType, > lldb_private::FileSpec&) in liblldbHost.a(HostInfoBase.cpp.o) > > "lldb_private::HostInfoMacOSX::ComputeHostArchitectureSupport(lldb_private::ArchSpec&, > lldb_private::ArchSpec&)", referenced from: > > lldb_private::HostInfoBase::GetArchitecture(lldb_private::HostInfoBase::ArchitectureKind) > in liblldbHost.a(HostInfoBase.cpp.o) > ld: symbol(s) not found for architecture x86_64 > > > _______________________________________________ > lldb-commits mailing list > [email protected] > http://lists.cs.uiuc.edu/mailman/listinfo/lldb-commits > > > > > -- > Todd Fiala | Software Engineer | [email protected] | 650-943-3180 > _______________________________________________ lldb-commits mailing list [email protected] http://lists.cs.uiuc.edu/mailman/listinfo/lldb-commits
