No, this seems great. Jim
> On Sep 8, 2014, at 5:19 PM, Zachary Turner <[email protected]> wrote: > > Hi Jim, > > I don't expect you to read this patch line by line, but do you have any > remaining high level concerns? > > > On Fri, Sep 5, 2014 at 3:28 PM, Zachary Turner <[email protected]> wrote: > Fixed issues suggested by Jim Ingham. HostThread is now a standalone class > that uses a facade pattern to hide the platform-specific details of the > different thread implementations. Various other style and naming issues have > also been addressed. > > http://reviews.llvm.org/D5198 > > Files: > include/lldb/Core/Communication.h > include/lldb/Core/DataBuffer.h > include/lldb/Core/Debugger.h > include/lldb/Host/Host.h > include/lldb/Host/HostInfoBase.h > include/lldb/Host/HostNativeThread.h > include/lldb/Host/HostNativeThreadBase.h > include/lldb/Host/HostThread.h > include/lldb/Host/ThisThread.h > include/lldb/Host/ThreadLauncher.h > include/lldb/Host/freebsd/HostInfoFreeBSD.h > include/lldb/Host/freebsd/HostThreadFreeBSD.h > include/lldb/Host/linux/HostInfoLinux.h > include/lldb/Host/linux/HostThreadLinux.h > include/lldb/Host/macosx/HostThreadMacOSX.h > include/lldb/Host/posix/HostThreadPosix.h > include/lldb/Host/windows/HostThreadWindows.h > include/lldb/Target/Process.h > include/lldb/lldb-private-enumerations.h > include/lldb/lldb-types.h > lldb.xcodeproj/project.pbxproj > source/API/SBHostOS.cpp > source/Core/Communication.cpp > source/Core/Debugger.cpp > source/Core/Log.cpp > source/Host/CMakeLists.txt > source/Host/common/Host.cpp > source/Host/common/HostInfoBase.cpp > source/Host/common/HostNativeThreadBase.cpp > source/Host/common/HostThread.cpp > source/Host/common/ThisThread.cpp > source/Host/common/ThreadLauncher.cpp > source/Host/freebsd/Host.cpp > source/Host/freebsd/HostInfoFreeBSD.cpp > source/Host/freebsd/HostThreadFreeBSD.cpp > source/Host/freebsd/ThisThread.cpp > source/Host/linux/Host.cpp > source/Host/linux/HostInfoLinux.cpp > source/Host/linux/HostThreadLinux.cpp > source/Host/linux/ThisThread.cpp > source/Host/macosx/Host.mm > source/Host/macosx/HostThreadMacOSX.mm > source/Host/macosx/ThisThread.cpp > source/Host/posix/HostThreadPosix.cpp > source/Host/windows/Host.cpp > source/Host/windows/HostThreadWindows.cpp > source/Host/windows/ThisThread.cpp > source/Plugins/Process/CMakeLists.txt > source/Plugins/Process/FreeBSD/ProcessMonitor.cpp > source/Plugins/Process/FreeBSD/ProcessMonitor.h > source/Plugins/Process/Linux/NativeProcessLinux.cpp > source/Plugins/Process/Linux/NativeProcessLinux.h > source/Plugins/Process/Linux/NativeThreadLinux.cpp > source/Plugins/Process/Linux/ProcessMonitor.cpp > source/Plugins/Process/Linux/ProcessMonitor.h > source/Plugins/Process/MacOSX-Kernel/ProcessKDP.cpp > source/Plugins/Process/MacOSX-Kernel/ProcessKDP.h > source/Plugins/Process/POSIX/POSIXThread.cpp > source/Plugins/Process/gdb-remote/GDBRemoteCommunication.cpp > source/Plugins/Process/gdb-remote/GDBRemoteCommunication.h > source/Plugins/Process/gdb-remote/ProcessGDBRemote.cpp > source/Plugins/Process/gdb-remote/ProcessGDBRemote.h > source/Target/Process.cpp > tools/lldb-gdbserver/lldb-gdbserver.cpp > _______________________________________________ lldb-commits mailing list [email protected] http://lists.cs.uiuc.edu/mailman/listinfo/lldb-commits
