This looks like a good change, thank you for coming up with it. Could you put
the statements on separate lines from the conditional expressions? Instead of
if (!m_exe_ctx.HasTargetScope()) result.AppendError
(GetInvalidTargetDescription());
more like this -
if (!m_exe_ctx.HasTargetScope())
result.AppendError (GetInvalidTargetDescription());
or
if (!m_exe_ctx.HasTargetScope())
{
result.AppendError (GetInvalidTargetDescription());
}
(in this case I think not using the braces will look cleaner). I know we have
a few examples of the if (cond) stmt; in lldb already but they are something we
need to clean up at some point.
J
> On Sep 16, 2014, at 10:06 PM, Paul Osmialowski <[email protected]> wrote:
>
> Many times during my recent activities I saw invalid frame error message. I
> found it totally useless - it does not give any clue why the error happened.
> It turned out that it can occur due to obvious reasons: no target selected,
> no process launched etc. With this patch it is easier to guess root cause of
> this error and save hours of unnecessary investigation.
>
> http://reviews.llvm.org/D5374
>
> Files:
> source/Interpreter/CommandObject.cpp
> <D5374.13769.patch>_______________________________________________
> lldb-commits mailing list
> [email protected]
> http://lists.cs.uiuc.edu/mailman/listinfo/lldb-commits
_______________________________________________
lldb-commits mailing list
[email protected]
http://lists.cs.uiuc.edu/mailman/listinfo/lldb-commits
