Looks good, a couple changes to match the lldb coding style better; please
commit.
================
Comment at: source/Plugins/MemoryHistory/asan/MemoryHistoryASan.cpp:119
@@ +118,3 @@
+
+ if (count <= 0) return;
+
----------------
Please split into two lines,
```
if (count <= 0)
return;
```
================
Comment at: source/Plugins/MemoryHistory/asan/MemoryHistoryASan.cpp:124
@@ +123,3 @@
+ std::vector<lldb::addr_t> pcs;
+ for (int i = 0; i < count; i++) {
+ addr_t pc = trace_sp->GetChildAtIndex(i, true)->GetValueAsUnsigned(0);
----------------
open brace ('{') on the next line,
```
for (int i = 0; i < count; i++)
{
```
================
Comment at: source/Plugins/MemoryHistory/asan/MemoryHistoryASan.cpp:126
@@ +125,3 @@
+ addr_t pc = trace_sp->GetChildAtIndex(i, true)->GetValueAsUnsigned(0);
+ if (pc == 0 || pc == 1 || pc == LLDB_INVALID_ADDRESS) continue;
+ pcs.push_back(pc);
----------------
Pls plist condition expr & command so they're on separate lines.
http://reviews.llvm.org/D5452
_______________________________________________
lldb-commits mailing list
[email protected]
http://lists.cs.uiuc.edu/mailman/listinfo/lldb-commits
