>>! In D5495#29, @endlessroad wrote:
> Add Host{Info, Thread}Android. They cannot directly inherit Host{Info, 
> Thread}Posix, because that would need linking the base classes, which will 
> cause linker error (some POSIX functions do not exist on Android)

It didn't occur to me that there would be linker errors.  As a result, I think 
your original solution of putting the #ifdef in Host[Info/Thread]Posix.cpp is 
probably better than this.  This results in a lot of code duplication as well, 
I'm fine with undoing these changes and going back to your original patch.  
Sorry for the trouble.

http://reviews.llvm.org/D5495



_______________________________________________
lldb-commits mailing list
[email protected]
http://lists.cs.uiuc.edu/mailman/listinfo/lldb-commits

Reply via email to