Looks good; one small suggestion, otherwise please commit.
================
Comment at: source/Plugins/SymbolFile/DWARF/DWARFDebugLine.cpp:427
@@ -426,1 +426,3 @@
prologue->min_inst_length = debug_line_data.GetU8(offset_ptr);
+ if (prologue->version >= 4)
+ prologue->maximum_operations_per_instruction =
debug_line_data.GetU8(offset_ptr);
----------------
Please add an else block here and assign a value of 1 to
maximum_operations_per_instruction. If anyone uses this in the line table
parser (unlikely unless we're adding Itanium support or something), we should
avoid having a garbage value for older DWARF files.
http://reviews.llvm.org/D5533
_______________________________________________
lldb-commits mailing list
[email protected]
http://lists.cs.uiuc.edu/mailman/listinfo/lldb-commits
