Hey Tong,
Some feedback:
* The jit-ness of this is more or less an implementation detail. Naming it
something related to expression evaluation seems like a better fit. Maybe
something like "evaluation-compiler-args".
* See question on custom handling that one arg in CommandObjectSettings.cpp.
That smells wrong. Why is that needed?
We'll also want to see if Sean Callanan has anything to add to this since it's
in the expression eval pipeline.
Thanks!
================
Comment at: source/Commands/CommandObjectSettings.cpp:223
@@ -222,4 +222,3 @@
- // Process possible options.
- if (!ParseOptions (cmd_args, result))
- return false;
+ if (::strncmp (command, "target.jit-args", ::strlen
("target.jit-args")) != 0) {
+ // Process possible options.
----------------
Hey Tong - why are you needing to special case this one argument here?
http://reviews.llvm.org/D5472
_______________________________________________
lldb-commits mailing list
[email protected]
http://lists.cs.uiuc.edu/mailman/listinfo/lldb-commits
