Nope, I don’t have commit access. Thanks for committing it for me. BTW, the patch is on phabricator here: http://reviews.llvm.org/D5923
-- Stephane Sezer On Oct 22, 2014, at 5:28 PM, Jason Molenda <[email protected]> wrote: > OK I think this patch is OK to commit. Do you have llvm commit access? I'll > commit it for you if not. > > J > >> On Oct 22, 2014, at 4:33 PM, Stephane Sezer <[email protected]> wrote: >> >> On Oct 21, 2014, at 6:18 PM, Jason Molenda <[email protected]> wrote: >> >>> Stephane, this looks good to me but I'm not personally involved with the >>> PlatformLinux. In debugserver we're using the bytes {0xfe, 0xde, 0xff, >>> 0xe7} for arm and {0xfe, 0xde} for thumb - but if the ARM ARM recommends >>> the byte sequences you've used here, that's probably for the best. >> >> It’s not ARM that recommends these bytes, it’s the linux kernel that expects >> them. You can see the code that installs these handlers here: >> >> https://github.com/torvalds/linux/blob/master/arch/arm/kernel/ptrace.c#L223 >> >>> fwiw you might want to set up an account at >>> https://urldefense.proofpoint.com/v1/url?u=http://reviews.llvm.org/&k=ZVNjlDMF0FElm4dQtryO4A%3D%3D%0A&r=g1GoAnQQskSBaWLJWw6X6w%3D%3D%0A&m=qf60Zuvb9LtQct3vGmu4meKbnPHmzk%2B6TRcEBXdgx78%3D%0A&s=0b9536baa0bcff9e58692a2a473d98b6ec16b716ee420d16101db2f88017b85d >>> - it's a pretty useful system to make sure that patches are tracked, >>> comments and revisions are recorded, assignment to people for review & >>> signoff, to when the change has been finally committed. >> >> I just did. Thanks for the advice. I'll upload my patches to phabricator now. >> >>> >>>> On Oct 21, 2014, at 1:26 PM, Stephane Sezer <[email protected]> wrote: >>>> >>>> source/Plugins/Platform/Linux/PlatformLinux.cpp | 28 >>>> +++++++++++++++++++++++++ >>>> 1 file changed, 28 insertions(+) >>>> >>>> This is part of the linux/arm support for LLDB. >>>> >>>> >>>> >>>> -- >>>> Stephane Sezer >>>> >>>> <0001-Implement-software-breakpoints-for-arm-in-Linux-plat.patch>_______________________________________________ >>>> lldb-commits mailing list >>>> [email protected] >>>> https://urldefense.proofpoint.com/v1/url?u=http://lists.cs.uiuc.edu/mailman/listinfo/lldb-commits&k=ZVNjlDMF0FElm4dQtryO4A%3D%3D%0A&r=g1GoAnQQskSBaWLJWw6X6w%3D%3D%0A&m=qf60Zuvb9LtQct3vGmu4meKbnPHmzk%2B6TRcEBXdgx78%3D%0A&s=ea5ea03f136217df707eb3e3a37b519ecdf769795b4a6cefb2a9ebfc949039f4 >>> >> > _______________________________________________ lldb-commits mailing list [email protected] http://lists.cs.uiuc.edu/mailman/listinfo/lldb-commits
