[Lldb-commits] [PATCH] Fix error handling in NativeProcessLinux::AttachToInferior

[Oleksiy Vyalov]

Hi clayborg, sbest,

Fix error handling in NativeProcessLinux::AttachToInferior - some return values 
were ignored.

http://reviews.llvm.org/D6158

Files:
  source/Plugins/Process/Linux/NativeProcessLinux.cpp

Index: source/Plugins/Process/Linux/NativeProcessLinux.cpp
===================================================================
--- source/Plugins/Process/Linux/NativeProcessLinux.cpp
+++ source/Plugins/Process/Linux/NativeProcessLinux.cpp
@@ -1423,11 +1423,18 @@
         if (log)
             log->Printf ("NativeProcessLinux::%s (pid = %" PRIi64 "): no default platform set", __FUNCTION__, pid);
         error.SetErrorString ("no default platform available");
+        return;
     }
 
     // Gather info about the process.
     ProcessInstanceInfo process_info;
-    platform_sp->GetProcessInfo (pid, process_info);
+    if (!platform_sp->GetProcessInfo (pid, process_info))
+    {
+        if (log)
+            log->Printf ("NativeProcessLinux::%s (pid = %" PRIi64 "): failed to get process info", __FUNCTION__, pid);
+        error.SetErrorString ("failed to get process info");
+        return;
+    }
 
     // Resolve the executable module
     ModuleSP exe_module_sp;

_______________________________________________
lldb-commits mailing list
lldb-commits@cs.uiuc.edu
http://lists.cs.uiuc.edu/mailman/listinfo/lldb-commits