Most of this seems okay, but in a couple of places you either write stub versions of functions that are missing from the Android NDK. std::to_string is done in the linux/Host.cpp, which seems like an appropriate place to put missing functions, but timegm and posix_openpt you do in the place where it is used (CXXFormatterFunctions.cpp and PseudoTerminal.cpp) which doesn’t seem right. All these platform deficiencies should be gathered up in one place so that they can be shared among the source files. Having them sprinkled throughout the sources will make the host dependencies harder to understand.
Also, I don’t know what your plans are for the EditLineAndroid, but if you are intending to just leave it as a stub, then call it EditLineStub or something like that, since there’s nothing Android specific about it. Jim > On Nov 7, 2014, at 7:45 AM, Andy Chien <[email protected]> wrote: > > Hi clayborg, jingham, tfiala, vharron, sbest, > > Added Android x86_64 support to the build compiled using standalone NDK. > > It needs a separate __ANDROID_NDK__ define instead of re-using ANDROID and/or > __ANDROID__ defines because different version of NDK for different targets > (arm vs x86 for example) seem to have some include path differences. > > This change does require some changes in LLVM. The patch for that was > submitted separately. > > http://reviews.llvm.org/D6166 > > Files: > CMakeLists.txt > cmake/LLDBDependencies.cmake > cmake/platforms/Android.cmake > include/lldb/Core/RegularExpression.h > include/lldb/Host/Config.h > include/lldb/Host/Editline.h > include/lldb/Host/android/Android.h > include/lldb/Host/android/Config.h > include/lldb/Host/android/editlineandroid.h > include/lldb/lldb-private.h > scripts/Python/modules/CMakeLists.txt > source/CMakeLists.txt > source/Core/ConnectionSharedMemory.cpp > source/DataFormatters/CXXFormatterFunctions.cpp > source/Host/CMakeLists.txt > source/Host/android/EditLineAndroid.cpp > source/Host/common/File.cpp > source/Host/common/Host.cpp > source/Host/common/Socket.cpp > source/Host/linux/Host.cpp > source/Host/posix/HostThreadPosix.cpp > source/Plugins/ObjectContainer/BSD-Archive/ObjectContainerBSDArchive.cpp > source/Plugins/Platform/Linux/PlatformLinux.cpp > source/Plugins/Process/Linux/NativeProcessLinux.cpp > source/Plugins/Process/Linux/ProcessMonitor.cpp > source/Plugins/Process/Utility/RegisterContextMacOSXFrameBackchain.cpp > source/Utility/PseudoTerminal.cpp > tools/CMakeLists.txt > tools/driver/Driver.cpp > tools/driver/Platform.h > tools/lldb-gdbserver/CMakeLists.txt > <D6166.15922.patch> _______________________________________________ lldb-commits mailing list [email protected] http://lists.cs.uiuc.edu/mailman/listinfo/lldb-commits
