I would vote to define the options struct in ConnectionFileDescriptor and have 
it not be an argument to the constructor, but to the connect method:

ConnectionFileDescriptor::Connect(const char *s, Error *error_ptr, const 
Options &options);

Make sure there is a default constructor for the Options class that sets 
m_child_processes_inherit to true;

And then pass the options from ConnectionFileDescriptor::Connect() down into 
all of the Socket::*Connect() calls

http://reviews.llvm.org/D6204



_______________________________________________
lldb-commits mailing list
[email protected]
http://lists.cs.uiuc.edu/mailman/listinfo/lldb-commits

Reply via email to