Hi Dawn, Some quick comments on the patch. >+ // Make sure we have a valid MI command This comment looks a bit misleading to me.
>+ CMIUtilString vMITextLine(vTextLine); >+ if (vTextLine.at(0) != '-') It seem that you are deciding the if a command is not an MI by checking for '-' in the first character. But MI command can have a sequence of digits before it. https://sourceware.org/gdb/onlinedocs/gdb/GDB_002fMI-Input-Syntax.html#GDB_002fMI-Input-Syntax The options that you are adding (-s | --source) are not being added in the help of lldb-mi. I wonder why are you dealing 'target create' separately. What is special about this command. Regards, Abid > -----Original Message----- > From: [email protected] [mailto:lldb-commits- > [email protected]] On Behalf Of [email protected] > Sent: 19 November 2014 07:28 > To: [email protected] > Cc: [email protected] > Subject: Re: [Lldb-commits] [PATCH] lldb-mi support for CLI commands and -s > option > > Doh! Let's try this again... > > On Tue, Nov 18, 2014 at 11:13:32AM -0800, [email protected] wrote: > > I didn't see a patch attached to this. > > > > Jim > > > > > On Nov 18, 2014, at 8:32 AM, [email protected] wrote: > > > > > > Adds support for using command files in lldb-mi via option -s, and > > > allows for non-MI commands to be entered in interpreter mode by > > > embedding them inside "-interpreter-exec" commands. > > > > > > Please review and commit? > > > > > > Thanks, > > > -Dawn > > > _______________________________________________ > > > lldb-commits mailing list > > > [email protected] > > > http://lists.cs.uiuc.edu/mailman/listinfo/lldb-commits _______________________________________________ lldb-commits mailing list [email protected] http://lists.cs.uiuc.edu/mailman/listinfo/lldb-commits
