Hi Dawn, I think some of the _MSC_VER are needed as they guard MSVC specific code so blanket replacing would not work. As I said in an earlier email, I have this working locally and can upstream later. So don't worry about it. I will try to review your OSX hang patch tomorrow if nobody else beats me to it.
Thanks, Abid > -----Original Message----- > From: [email protected] [mailto:[email protected]] > Sent: 26 November 2014 16:55 > To: Abid, Hafiz > Cc: Zachary Turner; [email protected]; [email protected]; lldb- > [email protected] > Subject: Re: [Lldb-commits] [PATCH] fix lldb-mi hang on OSX > > On Wed, Nov 26, 2014 at 11:34:31AM +0000, Abid, Hafiz wrote: > > +1 on changing _MSC_VER to _WIN32 unless the former is really required. > > I do a Windows build with mingw tools and had to do this change locally. > > I will perhaps can upstream those changes as I have the environment to > > test them. > > Again, the existing code used _MSC_VER. You'd have to ask the authors > why. > I certainly have no reason to use _MSC_VER over _Win32. My patch is about > fixing the hang on OSX. > > If you grep for _MSC_VER in lldb-mi, you'll see 43 uses of it. That should be > fixed in a separate commit. It was easy enough to create so I've attached a > patch for that, but someone else should verify it builds on Windows, and > which ever patch is committed second (the _MSC_VER patch or the OSX hang > fix) will need a little work because they will conflict. > > Please commit the fix for the OSX hang, then address the _MSC_VER issue? > > Thanks, > -Dawn _______________________________________________ lldb-commits mailing list [email protected] http://lists.cs.uiuc.edu/mailman/listinfo/lldb-commits
