I'll take a look later today. On Wed, Dec 17, 2014 at 6:59 AM Aidan Dodds <[email protected]> wrote:
> Hi zturner, clayborg, emaste, domipheus, > > The visual studio 2013 x64 build is failing due to some type differences > between 32bit and 64bit builds. > > The CONTEXT structure used in RegisterContextWindows_x86 changes its > fields based on the build. > Currently I have used #ifdefs to alternate between the different registers > for each build, is this an acceptable solution? > > It seems however that HostThreadWindows is largely 32bit specific, so > should there rather be a dedicated x64 version? > > In HostThreadWindows its seems that ULONG_PTR also changes its size based > on the machine type, however the argument for ExitThread() doesnt change in > a simmilar way. > I have created a proxy function to wrap ExitThread() so it can again be > used as a function pointer. > > If these changes are acceptable, would someone be able to commit these > fixes since I dont currently have commit access. > > Thanks, > Aidan > > http://reviews.llvm.org/D6704 > > Files: > source/Host/windows/HostThreadWindows.cpp > source/Plugins/Process/Windows/RegisterContextWindows_x86.cpp > > EMAIL PREFERENCES > http://reviews.llvm.org/settings/panel/emailpreferences/ >
_______________________________________________ lldb-commits mailing list [email protected] http://lists.cs.uiuc.edu/mailman/listinfo/lldb-commits
