The strtoul() calls you added have an issue in that if you type "123xyz" both calls with happily decode 123 as the resulting unsigned long and not error out. Args::StringToUInt32() actually correctly uses in the "endptr" argument and check "*endptr == '\0'" and return fail value which is why we really prefer to not have people use strtoul() manually because they always make these errors. I would prefer to keep using Args::StringToUInt32() if possible so we have one codebase that decodes numbers as strings. I also prefer to not have people remove code like "Args::StringTo*" just because it comes from some other folder in LLDB. LLDB is one large codebase and it needs to stay intact. Please fix the testing code so it can include the other parts of LLDB and reinstate the "#include "lldb/Interpreter/Args.h"" and use the appropriate calls.
REPOSITORY rL LLVM http://reviews.llvm.org/D6917 EMAIL PREFERENCES http://reviews.llvm.org/settings/panel/emailpreferences/ _______________________________________________ lldb-commits mailing list [email protected] http://lists.cs.uiuc.edu/mailman/listinfo/lldb-commits
