Looks ok to me. 2 comments though.
1. Why are changes in SBTarget when you are not using them.
2. I think the test cases for arguments are currently skipped
(@unittest2.skip("requires 'quotes' and 'CLI support' patches")). Currently, we
can test for argc. So I think at least that portion should be enabled as that
gives us some coverage. I will have to see why argv is not being evaluated.
If nobody else comments then I can commit this patch in a day or 2 with
modification suggested above.
http://reviews.llvm.org/D6965
EMAIL PREFERENCES
http://reviews.llvm.org/settings/panel/emailpreferences/
_______________________________________________
lldb-commits mailing list
[email protected]
http://lists.cs.uiuc.edu/mailman/listinfo/lldb-commits
