REPOSITORY rL LLVM ================ Comment at: source/Target/Platform.cpp:1272 @@ +1271,3 @@ + error = source_file.Read(buffer_sp->GetBytes(), bytes_read); + if (bytes_read) + { ---------------- Do we need to check for error here?
================ Comment at: source/Target/Platform.cpp:1274 @@ +1273,3 @@ + { + const uint64_t bytes_written = WriteFile(dest_file, offset, buffer_sp->GetBytes(), bytes_read, error); + offset += bytes_written; ---------------- ditto. http://reviews.llvm.org/D7049 EMAIL PREFERENCES http://reviews.llvm.org/settings/panel/emailpreferences/ _______________________________________________ lldb-commits mailing list lldb-commits@cs.uiuc.edu http://lists.cs.uiuc.edu/mailman/listinfo/lldb-commits