**Is it ok to remove friendship between SBLaunchInfo and SBTarget and make 
SBLaunchInfo::ref public since it will be used by SBPlatform and SBTarget? Or 
we can make SBPlatform its friend as well..**

Make SBPlatform a friend as well

**I'm going to add SBLaunchInfo::GetProcessID that will delegate to 
ProcessLaunchInfo::SBLaunchInfo - so, I can grab pid of launched process.**

sounds good

**Does it sound okay to extract SBLaunchInfo into separate SBLaunchInfo.h(cpp) 
files?**

Sure thing. Feel free to do the same for SBAttachInfo if you have time. I can 
deal with the fallout in the Xcode project if you don't have a Mac once you get 
those in.


http://reviews.llvm.org/D7263

EMAIL PREFERENCES
  http://reviews.llvm.org/settings/panel/emailpreferences/



_______________________________________________
lldb-commits mailing list
[email protected]
http://lists.cs.uiuc.edu/mailman/listinfo/lldb-commits

Reply via email to