I can't login to comment, I am home sick today, but I would rather not add anything extra to the SB header files. Can you move this static function into lldb_private::Target instead? We really should try to keep the SB layer free from any distractions.
> On Feb 6, 2015, at 9:30 AM, Oleksiy Vyalov <[email protected]> wrote: > > Hi vharron, clayborg, > > SBTarget::Attach, SBTarget::AttachToProcessWithID and > SBTarget::AttachToProcessWithName use the same core logic - extracted it into > new static method SBTarget::AttachToProcess. > Made SBTarget::AttachToProcess to support remote attach if a platform is > available and can debug a process - this makes TestHelloWorld to pass in case > of remote platform on Linux (test is passing when test suite and platform are > running on the same machine, fully distributed test run requires further > investigation). > > http://reviews.llvm.org/D7471 > > Files: > include/lldb/API/SBTarget.h > source/API/SBTarget.cpp > source/Plugins/Process/gdb-remote/GDBRemoteCommunicationServer.cpp > > EMAIL PREFERENCES > http://reviews.llvm.org/settings/panel/emailpreferences/ > <D7471.19490.patch> _______________________________________________ lldb-commits mailing list [email protected] http://lists.cs.uiuc.edu/mailman/listinfo/lldb-commits
