Lgtm - Enrico Sent from my iPhone
> On Feb 11, 2015, at 6:40 AM, Tamas Berghammer <[email protected]> wrote: > > Hi granata.enrico, > > Add missing check for LLDB_DISABLE_PYTHON in FormatManager > > Without the check the build fails if LLDB_DISABLE_PYTHON is defined because > AddCXXSummary not exist. > I don't know what is this code doing, so please check if this patch make > sense. > > http://reviews.llvm.org/D7558 > > Files: > source/DataFormatters/FormatManager.cpp > > Index: source/DataFormatters/FormatManager.cpp > =================================================================== > --- source/DataFormatters/FormatManager.cpp > +++ source/DataFormatters/FormatManager.cpp > @@ -1579,7 +1579,9 @@ > > TypeCategoryImpl::SharedPointer cm_category_sp = > GetCategory(m_coremedia_category_name); > > +#ifndef LLDB_DISABLE_PYTHON > AddCXXSummary(cm_category_sp, > lldb_private::formatters::CMTimeSummaryProvider, "CMTime summary provider", > ConstString("CMTime"), cm_flags); > +#endif // LLDB_DISABLE_PYTHON > } > > void > > EMAIL PREFERENCES > http://reviews.llvm.org/settings/panel/emailpreferences/ > <D7558.19750.patch>
_______________________________________________ lldb-commits mailing list [email protected] http://lists.cs.uiuc.edu/mailman/listinfo/lldb-commits
