In http://reviews.llvm.org/D7550#122769, @zturner wrote:
> In the future, please try to test the python changes more thoroughly. I know > we can't expect everyone to test everything on every platform, but I'm not > sure this was tested at all. There were lots of places **not** in Windows > specific codepaths that had syntax errors. Like calling a function that > didn't exist, returning a local variable of the wrong name, spaces instead of > tabs, and more. > > I'm glad that there's more people digging into this stuff, but please make > sure to test sufficiently. I'm uploading a new version of this which makes > it work insofar as I can test. Please feel free to download this revision > and make sure it works on other platforms. Sorry. I want to see what you had changed but when I selected Diff 4 in red column and Diff 6 in green column, it looked like you had removed all my changes in python scripts (see here <http://reviews.llvm.org/D7550?vs=19827&id=19846>). Is it a phabricator bug? http://reviews.llvm.org/D7550 EMAIL PREFERENCES http://reviews.llvm.org/settings/panel/emailpreferences/ _______________________________________________ lldb-commits mailing list [email protected] http://lists.cs.uiuc.edu/mailman/listinfo/lldb-commits
