REPOSITORY
rL LLVM
================
Comment at: tools/lldb-server/lldb-gdbserver.cpp:510-511
@@ -509,4 +509,2 @@
- Debugger::Initialize (NULL);
-
lldb::DebuggerSP debugger_sp = Debugger::CreateInstance ();
----------------
flackr wrote:
> tberghammer wrote:
> > Are you sure you don't have to initialize the debugger?
> It does not seem to be necessary, but I could update Debugger::initialize to
> take which lldb initialization we require if we want to initialize in case
> it's relied on to coordinate when to call lldb_private::Terminate if you
> think we should coordinate this through Debugger.
Sorry, parameters wouldn't work because it's not known at link time what values
the function will be called with, but Debugger could not implicitly call
lldb_private::Initialize though then the reference counting it does should
probably also be moved to the initialize method.
http://reviews.llvm.org/D7880
EMAIL PREFERENCES
http://reviews.llvm.org/settings/panel/emailpreferences/
_______________________________________________
lldb-commits mailing list
[email protected]
http://lists.cs.uiuc.edu/mailman/listinfo/lldb-commits
