Please see my comments.
================
Comment at: test/functionalities/watchpoint/hello_watchlocation/main.cpp:20
@@ -19,3 +19,3 @@
pthread_t g_thread_3 = NULL;
-
+pthread_barrier_t barrier;
char *g_char_ptr = NULL;
----------------
Please follow the existing naming convention here - g_barrier ?
================
Comment at: test/functionalities/watchpoint/hello_watchlocation/main.cpp:85
@@ -84,2 +84,3 @@
g_char_ptr = (char *)malloc (1);
*g_char_ptr = 0;
+ pthread_barrier_init(&barrier, NULL, 4);
----------------
My understanding the watchpoint is set for g_char_ptr variable but I don't see
any command to set watchpoint - is watchpoint here set implicitly by lldb?
================
Comment at: test/functionalities/watchpoint/hello_watchlocation/main.cpp:85
@@ -84,2 +84,3 @@
g_char_ptr = (char *)malloc (1);
*g_char_ptr = 0;
+ pthread_barrier_init(&barrier, NULL, 4);
----------------
ovyalov wrote:
> My understanding the watchpoint is set for g_char_ptr variable but I don't
> see any command to set watchpoint - is watchpoint here set implicitly by lldb?
Very minor unrelated thing - do we need to free this memory?
http://reviews.llvm.org/D7916
EMAIL PREFERENCES
http://reviews.llvm.org/settings/panel/emailpreferences/
_______________________________________________
lldb-commits mailing list
[email protected]
http://lists.cs.uiuc.edu/mailman/listinfo/lldb-commits
