In http://reviews.llvm.org/D8080#134977, @tberghammer wrote:
> We can, but ProcessPOSIXLog is a dependency for both of them, so I think it > isn't a good idea. > > If we want to reduce the amount of code duplication, then I would suggest to > simplify the process of registering a log channel to just one function call > (e.g.: create a ProcessPOSIXLog::RegisterLogger (const ConstString& name)) > function. But lldb_private::Initialize initializes everything (i.e. calls lldb_private::InitializeForLLGS), I think it's reasonable to expect there are some inter-dependencies. That being said I'm fine with moving it to ProcessPOSIXLog::RegisterLogger as long as it doesn't matter that it will be called twice, just trying to reduce code duplication. http://reviews.llvm.org/D8080 EMAIL PREFERENCES http://reviews.llvm.org/settings/panel/emailpreferences/ _______________________________________________ lldb-commits mailing list [email protected] http://lists.cs.uiuc.edu/mailman/listinfo/lldb-commits
