I have noticed 2 new failures:

  ======================================================================
  FAIL: test_with_dsym_and_run_command 
(TestTypeCompletion.TypeCompletionTestCase)
     Check that types only get completed when necessary.
  ----------------------------------------------------------------------
  Traceback (most recent call last):
    File "/Users/IliaK/p/llvm_delphi/tools/lldb/test/lldbtest.py", line 456, in 
wrapper
      return func(self, *args, **kwargs)
    File 
"/Users/IliaK/p/llvm_delphi/tools/lldb/test/functionalities/type_completion/TestTypeCompletion.py",
 line 20, in test_with_dsym_and_run_command
      self.type_completion_commands()
    File 
"/Users/IliaK/p/llvm_delphi/tools/lldb/test/functionalities/type_completion/TestTypeCompletion.py",
 line 61, in type_completion_commands
      self.assertFalse(p_type.IsTypeComplete(), 'vector<T> complete but it 
should not be')
  AssertionError: True is not False : vector<T> complete but it should not be
  Config=x86_64-clang
  ======================================================================
  FAIL: test_with_dwarf_and_run_command 
(TestTypeCompletion.TypeCompletionTestCase)
     Check that types only get completed when necessary.
  ----------------------------------------------------------------------
  Traceback (most recent call last):
    File "/Users/IliaK/p/llvm_delphi/tools/lldb/test/lldbtest.py", line 473, in 
wrapper
      return func(self, *args, **kwargs)
    File "/Users/IliaK/p/llvm_delphi/tools/lldb/test/lldbtest.py", line 537, in 
wrapper
      func(*args, **kwargs)
    File 
"/Users/IliaK/p/llvm_delphi/tools/lldb/test/functionalities/type_completion/TestTypeCompletion.py",
 line 28, in test_with_dwarf_and_run_command
      self.type_completion_commands()
    File 
"/Users/IliaK/p/llvm_delphi/tools/lldb/test/functionalities/type_completion/TestTypeCompletion.py",
 line 61, in type_completion_commands
      self.assertFalse(p_type.IsTypeComplete(), 'vector<T> complete but it 
should not be')
  AssertionError: True is not False : vector<T> complete but it should not be
  Config=x86_64-clang
  ----------------------------------------------------------------------

Therefore seems that my patch is wrong because this it works as expected.

But what should I do to get ValueObject::GetValueDidChange work? If we don't 
want to complete type on create should we do "ValueObject::Complete" method to 
complete it, before we will be interested in use of 
ValueObject::GetValueDidChange, right?


http://reviews.llvm.org/D8103

EMAIL PREFERENCES
  http://reviews.llvm.org/settings/panel/emailpreferences/



_______________________________________________
lldb-commits mailing list
[email protected]
http://lists.cs.uiuc.edu/mailman/listinfo/lldb-commits

Reply via email to