I have a question.

================
Comment at: source/API/SBTarget.cpp:136
@@ +135,3 @@
+{
+    return Target::TargetEventData::GetEventDataFromEvent(event.get()) != NULL;
+}
----------------
clayborg wrote:
> Make static functions in Target.h/cpp so we don't expose the TargetEventData 
> class to anyone.
Why you want to hide it in cpp file? It was done similarly to 
ThreadEventData/ProcessEventData/BreakpointEventData.

http://reviews.llvm.org/D8201

EMAIL PREFERENCES
  http://reviews.llvm.org/settings/panel/emailpreferences/



_______________________________________________
lldb-commits mailing list
lldb-commits@cs.uiuc.edu
http://lists.cs.uiuc.edu/mailman/listinfo/lldb-commits

Reply via email to