Re: [Lldb-commits] [PATCH] Add -p and -r options to lldb-mi command -file-exec-file-and-symbols to support iOS debugging on macOS

[Ilia K]

If be honest I'd prefer to add this comment into tools/lldb-mi/MICmdCmdFile.h. 
In that case everyone who are interesting in "-file-exec-and-symbols" will see 
that it has non-standard options.

There are 2 small fixes (see below):


================
Comment at: tools/lldb-mi/MICmdCmdFile.h:72
@@ -71,1 +71,3 @@
         m_constStrArgThreadGrp; // Not handled by *this command. Not specified 
in MI spec but Eclipse gives this option sometimes
+    const CMIUtilString m_constStrArgNamedPlatformName; //added to support iOS 
platform selection
+    const CMIUtilString m_constStrArgNamedRemotePath; //added to support iOS 
device remote file location
----------------
A little fix:
```
const CMIUtilString m_constStrArgNamedPlatformName; // Added to support iOS 
platform selection
```

================
Comment at: tools/lldb-mi/MICmdCmdFile.h:73
@@ -72,1 +72,3 @@
+    const CMIUtilString m_constStrArgNamedPlatformName; //added to support iOS 
platform selection
+    const CMIUtilString m_constStrArgNamedRemotePath; //added to support iOS 
device remote file location
 };
----------------
A little fix:
```
const CMIUtilString m_constStrArgNamedRemotePath; // Added to support iOS 
device remote file location
```

http://reviews.llvm.org/D8210

EMAIL PREFERENCES
  http://reviews.llvm.org/settings/panel/emailpreferences/



_______________________________________________
lldb-commits mailing list
lldb-commits@cs.uiuc.edu
http://lists.cs.uiuc.edu/mailman/listinfo/lldb-commits