Re: [Lldb-commits] [PATCH] Remove IDE_MI_APP_EXIT_OK msg on exit (MI)

[Ilia K]

Hello @abidh,

How you think, should we keep a logging on exit?


================
Comment at: tools/lldb-mi/MIDriverMgr.cpp:114-133
@@ -113,26 +113,22 @@
 
     if (vbAppExitOk)
     {
-#if _DEBUG
-        CMICmnStreamStdout::Instance().Write(MIRSRC(IDE_MI_APP_EXIT_OK)); // 
Both stdout and Log
-#else
-        CMICmnLog::WriteLog(MIRSRC(IDE_MI_APP_EXIT_OK)); // Just to the Log
-#endif // _DEBUG
+        CMICmnLog::WriteLog(MIRSRC(IDE_MI_APP_EXIT_OK));
     }
     else
     {
         CMICmnLog &rAppLog = CMICmnLog::Instance();
         if (rAppLog.GetEnabled())
         {
             const CMIUtilString msg(
                 CMIUtilString::Format(MIRSRC(IDE_MI_APP_EXIT_WITH_PROBLEM), 
CMICmnLogMediumFile::Instance().GetFileName().c_str()));
             CMICmnStreamStdout::Instance().Write(msg);
         }
         else
         {
             const CMIUtilString msg(
                 
CMIUtilString::Format(MIRSRC(IDE_MI_APP_EXIT_WITH_PROBLEM_NO_LOG), 
CMICmnLogMediumFile::Instance().GetFileName().c_str()));
             CMICmnStreamStdout::Instance().Write(msg);
         }
     }
 
----------------
or I should remove all these lines?

http://reviews.llvm.org/D8446

EMAIL PREFERENCES
  http://reviews.llvm.org/settings/panel/emailpreferences/



_______________________________________________
lldb-commits mailing list
lldb-commits@cs.uiuc.edu
http://lists.cs.uiuc.edu/mailman/listinfo/lldb-commits