Looks like a good separation of dependencies, thanks for doing this.
================
Comment at: include/lldb/Core/Debugger.h:70
@@ -76,3 +69,3 @@
- static void
+ static int
Terminate ();
----------------
You should document what this returns since it seems non-obvious.
================
Comment at: include/lldb/Initialization/InitializeLLDB.h:43
@@ +42,3 @@
+/// function calls. No lldb functions should be called after
+/// calling this function without again calling DCInitialize()
+/// again.
----------------
DCInitialize should be just Initialize right?
================
Comment at: include/lldb/Initialization/InitializeLLDB.h:55
@@ +54,3 @@
+/// function calls. No lldb functions should be called after
+/// calling this function without again calling DCInitialize()
+/// again.
----------------
ditto.
================
Comment at: source/Core/Debugger.cpp:420
@@ -428,3 +419,3 @@
{
lldb_initialized = true;
g_shared_debugger_refcount++;
----------------
I think this is no longer used.
================
Comment at: source/Core/Debugger.cpp:438
@@ -457,2 +437,3 @@
}
+ return g_shared_debugger_refcount;
}
----------------
Might it not make more sense to just move the ref counting to InitializeLLDB at
this point? Do we still depend on calls to Debugger::Initialize adding to the
ref count? And if so that would represent a chance to not terminate at shutdown
due to a pre-existing debugger reference right?
http://reviews.llvm.org/D8428
EMAIL PREFERENCES
http://reviews.llvm.org/settings/panel/emailpreferences/
_______________________________________________
lldb-commits mailing list
[email protected]
http://lists.cs.uiuc.edu/mailman/listinfo/lldb-commits
