This bug isn't specific to Microsoft layout. Clang as a general rule requires fields to be added in offset order, and iterating over a dense map doesn't give you that.
I'll let majnemer or rnk comment on the ExternalASTSource interface On Tue, Mar 24, 2015 at 10:15 AM Sean Callanan <scalla...@apple.com> wrote: > As an aside, when laying out a RecordDecl, you have the ordering for its > fields right in the RecordDecl. If MicrosoftRecordLayoutBuilder relying on > the llvm::DenseMap for ordering, I think it's MicrosoftRecordLayoutBuilder > that has the bug. By my understanding of how record layout works, it > should only be using the map to go from fields/bases to offsets – nothing > else. > > > REPOSITORY > rL LLVM > > http://reviews.llvm.org/D8512 > > EMAIL PREFERENCES > http://reviews.llvm.org/settings/panel/emailpreferences/ > > >
_______________________________________________ lldb-commits mailing list lldb-commits@cs.uiuc.edu http://lists.cs.uiuc.edu/mailman/listinfo/lldb-commits
