The only thing that bothers me a bit about this patch is that somebody might think we need to go clean up all the places where a thread doesn't have a frame 0, and worse, actually try to do something reasonable in that case. That would be wasted effort. To that end, an assert here might in fact be a better solution. In any case, it might be good to put a comment in Thread.h making it clear that GetFrameAtIndex(0) is always expected to return a valid frame.
Jim > On Mar 23, 2015, at 9:43 PM, Stephane Sezer <[email protected]> wrote: > > Agreed. The only small benefit of this patch is to help a bit during target > bring up. > > > http://reviews.llvm.org/D8574 > > EMAIL PREFERENCES > http://reviews.llvm.org/settings/panel/emailpreferences/ > > _______________________________________________ lldb-commits mailing list [email protected] http://lists.cs.uiuc.edu/mailman/listinfo/lldb-commits
