I would prefer each plug-in use its own namespace, even if the the shallow version is fine. I would just like people to see the error of their ways if they are in ProcessLinux.cpp and you see:
lldb_private::gdb_remote::something(); or if "using namespace lldb_private;": gdb_remote::something(); This should be a good indication that the abstraction was broken since you are in ProcessLinux.cpp and you are accessing code from a plug-in. Where as if you saw: lldb_private::something(); or if "using namespace lldb_private;": something(); You might think the above code would be OK since it is in the lldb_private namespace, whereas seeing "gdb_remote" namespace quickly tells you something is up. http://reviews.llvm.org/D8654 EMAIL PREFERENCES http://reviews.llvm.org/settings/panel/emailpreferences/ _______________________________________________ lldb-commits mailing list [email protected] http://lists.cs.uiuc.edu/mailman/listinfo/lldb-commits
