[Lldb-commits] [PATCH] Fix socket leak in lldb-server platform

[Vince Harron]

Hi clayborg, flackr, tberghammer,

lldb-server server process was holding on to a connection to every
client that connected.  This continued until the process hit it's
file limit and exited.

http://reviews.llvm.org/D8697

Files:
  tools/lldb-server/lldb-platform.cpp

Index: tools/lldb-server/lldb-platform.cpp
===================================================================
--- tools/lldb-server/lldb-platform.cpp
+++ tools/lldb-server/lldb-platform.cpp
@@ -287,6 +287,10 @@
             while (waitpid(-1, nullptr, WNOHANG) > 0);
             if (fork())
             {
+                // Parent doesn't need a connection to the lldb client
+                delete socket;
+                socket = nullptr;
+
                 // Parent will continue to listen for new connections.
                 continue;
             }

EMAIL PREFERENCES
  http://reviews.llvm.org/settings/panel/emailpreferences/

Index: tools/lldb-server/lldb-platform.cpp
===================================================================
--- tools/lldb-server/lldb-platform.cpp
+++ tools/lldb-server/lldb-platform.cpp
@@ -287,6 +287,10 @@
             while (waitpid(-1, nullptr, WNOHANG) > 0);
             if (fork())
             {
+                // Parent doesn't need a connection to the lldb client
+                delete socket;
+                socket = nullptr;
+
                 // Parent will continue to listen for new connections.
                 continue;
             }

_______________________________________________
lldb-commits mailing list
lldb-commits@cs.uiuc.edu
http://lists.cs.uiuc.edu/mailman/listinfo/lldb-commits