This looks good, just make the RAII change so that everybody editing the code
doesn't have to remember this.
================
Comment at: source/Expression/ClangASTSource.cpp:483
@@ -465,1 +482,3 @@
+ {
+ m_active_lexical_decls.erase(context_decl);
return ELR_Failure;
----------------
This should be done in a RAII way, with some object that deregisters
context_decl when the function returns. That way we don't have to remember to
explicitly deregister it wherever we return.
http://reviews.llvm.org/D8561
EMAIL PREFERENCES
http://reviews.llvm.org/settings/panel/emailpreferences/
_______________________________________________
lldb-commits mailing list
[email protected]
http://lists.cs.uiuc.edu/mailman/listinfo/lldb-commits
