Hi Tamas, Some inline comments about these tests.
================ Comment at: test/functionalities/inferior-assert/TestInferiorAssert.py:98 @@ -97,1 +97,3 @@ + def check_register_read_working(self): + if self.getArchitecture() in ['x86_64', 'i386']: ---------------- Hi Tamas, Can we put this function in one place and use it from there instead on duplicating it in every other file? In my opinion we should consider separating such tests by architecture and put them in a library or file that can imported otherwise these will be very hard to maintain as our test set grows large. http://reviews.llvm.org/D8702 EMAIL PREFERENCES http://reviews.llvm.org/settings/panel/emailpreferences/ _______________________________________________ lldb-commits mailing list [email protected] http://lists.cs.uiuc.edu/mailman/listinfo/lldb-commits
