It seems like GetOsFromOSABI's purpose is to compensate for
ArchSpec::SetArchitecture. I think it would be better to improve
SetArchitecture. I will post a change showing how this could be done
shorty.
Tom
On 04/27/2015 12:58 PM, Greg Clayton wrote:
Ok, just make sure that the unknown is wanted. I would say that
GetOsFromOSABI() should be renamed to UpdateOSAndVendorFromOSABI() and it
should take the ArchSpec and set the vendor and OS correctly. Specified
unknowns are OK when they are desired, but if this function doesn't recognize
the OSABI and it doesn't set anything, they should be left and unspecified
unknowns.
REPOSITORY
rL LLVM
http://reviews.llvm.org/D9292
EMAIL PREFERENCES
http://reviews.llvm.org/settings/panel/emailpreferences/
_______________________________________________
lldb-commits mailing list
[email protected]
http://lists.cs.uiuc.edu/mailman/listinfo/lldb-commits
