LGTM - Enrico Sent from my iPhone
> On May 7, 2015, at 8:15 AM, Pavel Labath <lab...@google.com> wrote: > > Hi granata.enrico, zturner, > > This changes lldb_assert to accept bool expressions as the parameter, this is > because some > objects (such as std::shared_ptr) are convertible to bool, but are not > convertible to int, which > leads to surprising errors. > > http://reviews.llvm.org/D9565 > > Files: > include/lldb/Utility/LLDBAssert.h > source/Utility/LLDBAssert.cpp > > Index: include/lldb/Utility/LLDBAssert.h > =================================================================== > --- include/lldb/Utility/LLDBAssert.h > +++ include/lldb/Utility/LLDBAssert.h > @@ -20,7 +20,7 @@ > > namespace lldb_private { > void > - lldb_assert (int expression, > + lldb_assert (bool expression, > const char* expr_text, > const char* func, > const char* file, > Index: source/Utility/LLDBAssert.cpp > =================================================================== > --- source/Utility/LLDBAssert.cpp > +++ source/Utility/LLDBAssert.cpp > @@ -17,7 +17,7 @@ > using namespace lldb_private; > > void > -lldb_private::lldb_assert (int expression, > +lldb_private::lldb_assert (bool expression, > const char* expr_text, > const char* func, > const char* file, > > EMAIL PREFERENCES > http://reviews.llvm.org/settings/panel/emailpreferences/ > <D9565.25191.patch>
_______________________________________________ lldb-commits mailing list lldb-commits@cs.uiuc.edu http://lists.cs.uiuc.edu/mailman/listinfo/lldb-commits
