That seems fine as a "reduce noise by not showing flags when set to their default values."
OTOH we should NOT be writing tests that rely on the exact format of break list output, except as mediated by the breakpoint setting commands in lldbutil.py. I didn't look at the tests that were failing, I'm a bit busy right now. But if people are using the command line to set breakpoints and check breakpoints and not using the run_break_set_by_* functions, they should stop doing that. We should be able to change the output from break list and ONLY have to change this set of functions, not go adjusting test suite code all over the testsuite... So whoever wrote these tests should clean them up. Jim > On May 18, 2015, at 6:21 AM, Ilia K <ki.s...@gmail.com> wrote: > > @jingham, what you think about hiding of the exact_match field in BP > description when it's false? It will fix these errors: > http://lab.llvm.org:8011/builders/lldb-x86_64-darwin-13.4/builds/2941 > > > REPOSITORY > rL LLVM > > http://reviews.llvm.org/D9273 > > EMAIL PREFERENCES > http://reviews.llvm.org/settings/panel/emailpreferences/ > > _______________________________________________ lldb-commits mailing list lldb-commits@cs.uiuc.edu http://lists.cs.uiuc.edu/mailman/listinfo/lldb-commits
