Sorry, I mistyped the comment in the review. My fix "does not" have the issue the Ilia raised. That is, it does return names in simple lists when no values are asked for.
-----Original Message----- From: Hafiz Abid Qadeer [mailto:abidh....@gmail.com] Sent: Friday, May 29, 2015 8:25 AM To: Paul Maybee; ki.s...@gmail.com; Chuck Ries; abidh....@gmail.com Cc: lldb-commits@cs.uiuc.edu Subject: Re: [PATCH] Add type result to lldb-mi variables lists when simple-values is specified. In http://reviews.llvm.org/D10106#180919, @paulmaybee wrote: > Hi Abid, > Yeah looks like you are solving the same problem. I didn't see your review > in progress. I do, however, believe my patch also fixes both the issues you > address with yours, and does have the issue that Ilia raises. > -Paul If you can modify your patch so that it addresses the 2nd issue as Ilia wants then it is ok for me. Please see the bugzilla entry that is mentioned in my revision for more details. Otherwise you can wait for me to get around to fixing it. Thanks, Abid http://reviews.llvm.org/D10106 EMAIL PREFERENCES http://reviews.llvm.org/settings/panel/emailpreferences/ _______________________________________________ lldb-commits mailing list lldb-commits@cs.uiuc.edu http://lists.cs.uiuc.edu/mailman/listinfo/lldb-commits
