clayborg requested changes to this revision.
clayborg added a comment.
This revision now requires changes to proceed.

The current frame really isn't a good indicator of the language that one should 
use for a breakpoint you are want to set by name.

I would rather see smarts go into Module::PrepareForFunctionNameLookup() and 
teach it to pull apart names like "ns.foo" and do the right thing. If a string 
comes into Module::PrepareForFunctionNameLookup() that contains 
<indentifier>.<indentifier> repeated as many times as needed 
(<indentifier>.<indentifier>.<indentifier>.<indentifier>) then we should 
correctly pull those apart and search for "foo" and then match against "ns.foo" 
(just like Module::PrepareForFunctionNameLookup() takes "ns::foo" and looks up 
"foo" and then matches agains "ns::foo"). I don't think we need a language 
indicator to tell us, we should be able to just break it up without that hint. 
We could provide a language hint to Module::PrepareForFunctionNameLookup() if 
we want to and then have the user specify "--language pascal" when doing the 
"breakpoint set --name ns.foo --language pascal", but we shouldn't be using any 
frame's compile unit language to do so.


Repository:
  rL LLVM

http://reviews.llvm.org/D11119




_______________________________________________
lldb-commits mailing list
lldb-commits@cs.uiuc.edu
http://lists.cs.uiuc.edu/mailman/listinfo/lldb-commits

Reply via email to