[Lldb-commits] [lldb] r242969 - Don't specify languages when setting breakpoints in C function names. We won't be able to tell from the symbol value alone what language the symbol is.

[Greg Clayton]

Author: gclayton
Date: Wed Jul 22 18:45:52 2015
New Revision: 242969

URL: http://llvm.org/viewvc/llvm-project?rev=242969&view=rev
Log:
Don't specify languages when setting breakpoints in C function names. We won't 
be able to tell from the symbol value alone what language the symbol is.


Modified:
    
lldb/trunk/source/Plugins/LanguageRuntime/CPlusPlus/ItaniumABI/ItaniumABILanguageRuntime.cpp
    
lldb/trunk/source/Plugins/LanguageRuntime/ObjC/AppleObjCRuntime/AppleObjCRuntimeV1.cpp
    
lldb/trunk/source/Plugins/LanguageRuntime/ObjC/AppleObjCRuntime/AppleObjCRuntimeV2.cpp

Modified: 
lldb/trunk/source/Plugins/LanguageRuntime/CPlusPlus/ItaniumABI/ItaniumABILanguageRuntime.cpp
URL: 
http://llvm.org/viewvc/llvm-project/lldb/trunk/source/Plugins/LanguageRuntime/CPlusPlus/ItaniumABI/ItaniumABILanguageRuntime.cpp?rev=242969&r1=242968&r2=242969&view=diff
==============================================================================
--- 
lldb/trunk/source/Plugins/LanguageRuntime/CPlusPlus/ItaniumABI/ItaniumABILanguageRuntime.cpp
 (original)
+++ 
lldb/trunk/source/Plugins/LanguageRuntime/CPlusPlus/ItaniumABI/ItaniumABILanguageRuntime.cpp
 Wed Jul 22 18:45:52 2015
@@ -420,7 +420,7 @@ ItaniumABILanguageRuntime::CreateExcepti
                                                                   
exception_names.data(),
                                                                   
exception_names.size(),
                                                                   
eFunctionNameTypeBase,
-                                                                  
eLanguageTypeC_plus_plus,
+                                                                  
eLanguageTypeUnknown,
                                                                   
eLazyBoolNo));
 
     return resolver_sp;

Modified: 
lldb/trunk/source/Plugins/LanguageRuntime/ObjC/AppleObjCRuntime/AppleObjCRuntimeV1.cpp
URL: 
http://llvm.org/viewvc/llvm-project/lldb/trunk/source/Plugins/LanguageRuntime/ObjC/AppleObjCRuntime/AppleObjCRuntimeV1.cpp?rev=242969&r1=242968&r2=242969&view=diff
==============================================================================
--- 
lldb/trunk/source/Plugins/LanguageRuntime/ObjC/AppleObjCRuntime/AppleObjCRuntimeV1.cpp
 (original)
+++ 
lldb/trunk/source/Plugins/LanguageRuntime/ObjC/AppleObjCRuntime/AppleObjCRuntimeV1.cpp
 Wed Jul 22 18:45:52 2015
@@ -132,7 +132,7 @@ AppleObjCRuntimeV1::CreateExceptionResol
         resolver_sp.reset (new BreakpointResolverName (bkpt,
                                                        "objc_exception_throw",
                                                        eFunctionNameTypeBase,
-                                                       eLanguageTypeObjC,
+                                                       eLanguageTypeUnknown,
                                                        Breakpoint::Exact,
                                                        eLazyBoolNo));
     // FIXME: don't do catch yet.

Modified: 
lldb/trunk/source/Plugins/LanguageRuntime/ObjC/AppleObjCRuntime/AppleObjCRuntimeV2.cpp
URL: 
http://llvm.org/viewvc/llvm-project/lldb/trunk/source/Plugins/LanguageRuntime/ObjC/AppleObjCRuntime/AppleObjCRuntimeV2.cpp?rev=242969&r1=242968&r2=242969&view=diff
==============================================================================
--- 
lldb/trunk/source/Plugins/LanguageRuntime/ObjC/AppleObjCRuntime/AppleObjCRuntimeV2.cpp
 (original)
+++ 
lldb/trunk/source/Plugins/LanguageRuntime/ObjC/AppleObjCRuntime/AppleObjCRuntimeV2.cpp
 Wed Jul 22 18:45:52 2015
@@ -714,7 +714,7 @@ AppleObjCRuntimeV2::CreateExceptionResol
         resolver_sp.reset (new BreakpointResolverName (bkpt,
                                                        "objc_exception_throw",
                                                        eFunctionNameTypeBase,
-                                                       eLanguageTypeObjC,
+                                                       eLanguageTypeUnknown,
                                                        Breakpoint::Exact,
                                                        eLazyBoolNo));
     // FIXME: We don't do catch breakpoints for ObjC yet.


_______________________________________________
lldb-commits mailing list
lldb-commits@cs.uiuc.edu
http://lists.cs.uiuc.edu/mailman/listinfo/lldb-commits