ki.stfu added inline comments. ================ Comment at: test/tools/lldb-mi/TestMiLibraryLoaded.py:32 @@ -33,1 +31,3 @@ + "=library-loaded,id=\"%s\",target-name=\"%s\",host-name=\"%s\",symbols-loaded=\"0\",loaded_addr=\"-\",size=\"[0-9]+\"" % (path, path, path) + ]) ---------------- ChuckR wrote: > ki.stfu wrote: > > it may cause false negative on systems where full path to lldb dir contains > > bad symbols that should be escaped (" or \ etc). I had the same issue in > > MiSyntaxTestCase. > Any suggestions for checking the size then? I could make a second test that > only checks for the size field? I think u can use an analogue of AddSlashes: ``` >>> def add_slashes(x): return x.replace("\\", "\\\\").replace("\"", >>> "\\\"").replace("\'", "\\\'") ... >>> print "C:\\foo\\bar\\baz\"\'ext" C:\foo\bar\baz"'ext >>> print add_slashes("C:\\foo\\bar\\baz\"\'ext") C:\\foo\\bar\\baz\"\'ext ```
http://reviews.llvm.org/D9716 _______________________________________________ lldb-commits mailing list lldb-commits@cs.uiuc.edu http://lists.cs.uiuc.edu/mailman/listinfo/lldb-commits