jingham added a comment.

That seems good, except take out the use of auto in the first diff.  We try not 
to use "auto" for trivially nameable types like lldb::pid_t.  When you are 
declaring a variable where you would have to scratch your head more than twice 
to figure out how to write the type of the thing, then auto is a real help.  
But for simple types it doesn't offer any benefit and makes reading the code a 
little bit harder...


Repository:
  rL LLVM

http://reviews.llvm.org/D11519




_______________________________________________
lldb-commits mailing list
lldb-commits@cs.uiuc.edu
http://lists.cs.uiuc.edu/mailman/listinfo/lldb-commits

Reply via email to