ki.stfu requested changes to this revision.
ki.stfu added a comment.
This revision now requires changes to proceed.
I'd prefer to declare all static functions as private static methods.
================
Comment at: tools/lldb-mi/MICmnMIOutOfBandRecord.cpp:16
@@ +15,3 @@
+static const char *
+MapOutOfBandToText(CMICmnMIOutOfBandRecord::OutOfBand_e veType)
+{
----------------
CMICmnMIOutOfBandRecord::MapOutOfBandToText
================
Comment at: tools/lldb-mi/MICmnMIOutOfBandRecord.cpp:56
@@ +55,3 @@
+static const char *
+MapOutOfBandToToken(CMICmnMIOutOfBandRecord::OutOfBand_e veType)
+{
----------------
CMICmnMIOutOfBandRecord::MapOutOfBandToToken
================
Comment at: tools/lldb-mi/MICmnMIOutOfBandRecord.cpp:102
@@ +101,3 @@
+//--
+static CMIUtilString BuildAsyncRecord(CMICmnMIOutOfBandRecord::OutOfBand_e
veType)
+{
----------------
And please follow to the style:
```
static CMIUtilString
BuildAsyncRecord(CMICmnMIOutOfBandRecord::OutOfBand_e veType)
```
================
Comment at: tools/lldb-mi/MICmnMIOutOfBandRecord.cpp:102
@@ +101,3 @@
+//--
+static CMIUtilString BuildAsyncRecord(CMICmnMIOutOfBandRecord::OutOfBand_e
veType)
+{
----------------
ki.stfu wrote:
> And please follow to the style:
> ```
> static CMIUtilString
> BuildAsyncRecord(CMICmnMIOutOfBandRecord::OutOfBand_e veType)
> ```
CMICmnMIOutOfBandRecord::BuildAsyncRecord
http://reviews.llvm.org/D11751
_______________________________________________
lldb-commits mailing list
lldb-commits@cs.uiuc.edu
http://lists.cs.uiuc.edu/mailman/listinfo/lldb-commits
