dawn added a subscriber: dawn.
dawn raised a concern with this commit.
dawn added a comment.
This broke dotest.py on OSX. When running tests via:
./dotest.py -v --executable $INSTALLDIR/bin/lldb
Before this commit, all tests run:
Configuration: arch=x86_64 compiler=clang
----------------------------------------------------------------------
Collected 1324 tests
1: test_sb_api_directory (TestPublicAPIHeaders.SBDirCheckerCase)
[...]
850: test_disassemble_invalid_vst_1_64_raw_data
(TestDisassemble_VST1_64.Disassemble_VST1_64)
Test disassembling invalid vst1.64 raw bytes with the API. ... ok
851: test_disassemble_raw_data
(TestDisassembleRawData.DisassembleRawDataTestCase)
Test disassembling raw bytes with the API. ... ok
[...]
----------------------------------------------------------------------
Ran 1324 tests in 4017.285s
FAILED (failures=2, errors=3, skipped=118, expected failures=61, unexpected
successes=28)
After this commit, all tests folloing
test_disassemble_invalid_vst_1_64_raw_data get ERRORs:
Configuration: arch=x86_64 compiler=clang
----------------------------------------------------------------------
Collected 1324 tests
1: test_sb_api_directory (TestPublicAPIHeaders.SBDirCheckerCase)
Test the SB API directory and make sure there's no unwanted stuff. ...
skipped 'skip because LLDB.h header not found'
[...]
850: test_disassemble_invalid_vst_1_64_raw_data
(TestDisassemble_VST1_64.Disassemble_VST1_64)
Test disassembling invalid vst1.64 raw bytes with the API. ... ok
ERROR
ERROR
ERROR
[...]
---------------------------------------------------------------------
Ran 850 tests in 3052.121s
FAILED (failures=2, errors=86, skipped=40, expected failures=57, unexpected
successes=25)
Users:
ted (Author)
dawn (Auditor)
http://reviews.llvm.org/rL237053
_______________________________________________
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
