tfiala added a comment.

Also, I should mention this was tested on OS X in addition to Linux.

Let me know when you get a chance to run it on Windows, Zachary.

> Are there any plans to actually just kill dosep.py at some point?


Hmm not seeing my response to this from my phone last night, so at the cost of 
potentially repeating:
Absolutely.  I think there is a fair amount of cleanup that could happen to the 
test running code.  I'd expect later to see the dosep.py functionality turn 
into an LLDBTestRunner class or something similar, with a concrete impl for the 
single-serialized running and a separate one for multithreaded running.   There 
are many areas that could be cleaned up (both in terms of code organization and 
things like pep8/pylint --- a few of which I took care of in this change but 
the majority of which I left unchanged).

My goal for this particular change was to be minimally different at the 
implementation level to simplify the transition --- get the user interface 
right (no dosep.py from the user's point of view).  In using a minimal 
implementation change, I'm also hopeful to avoid things like breaking the 
Windows build.


http://reviews.llvm.org/D12587



_______________________________________________
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

Reply via email to