clayborg requested changes to this revision.
This revision now requires changes to proceed.
================
Comment at: include/lldb/Host/FileSpec.h:516
@@ -514,1 +515,3 @@
+ FileSpec
+ GetSymbolicLinkTarget () const;
----------------
rename to ResolveSymbolicLink?
================
Comment at: source/Host/common/FileSpec.cpp:818
@@ +817,3 @@
+ {
+ return FileSpec();
+ }
----------------
rename to ResolveSymbolicLink() and return a copy of this object if it isn't a
symbolic link
================
Comment at: source/Host/common/HostInfoBase.cpp:310-312
@@ +309,5 @@
+
+ if (lldb_file_spec.IsSymbolicLink()) {
+ lldb_file_spec = lldb_file_spec.GetSymbolicLinkTarget();
+ }
+
----------------
No need to check if we change the behavior of ResolveSymbolicLink, this code
will just be:
```
lldb_file_spec = lldb_file_spec.ResolveSymbolicLink();
```
http://reviews.llvm.org/D12984
_______________________________________________
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
